-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Support range grammar #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Given that we prefer not to keep the tool stateless, we can't easily tell if this is the "first" time we've run, i.e. to do a special once-only cleanup. We could use a hack like looking for any past pull requests created by our account, but I prefer to avoid that. Some possible options:
I think the second option is better, but perhaps there's a problem if someone runs the tool the first time on a repo with completely unpinned dependencies - you could end up with dozens or even hundreds of pull requests. Perhaps then we provide a special option for the tool where people can manually initialise a repository. e.g. run it with a
In theory this shouldn't make any different to the project, because it would simply be pinning the same dependency versions that npm would be resolving anyway. |
I wonder if a tool to pin all dependencies already exists, but I can't find it. It's not the same as |
Uh oh!
There was an error while loading. Please reload this page.
So far it's been assumed/tested that existing
package.json
dependencies use pinned versions, such as1.6.0
and not such as~1.6
. So for now, this is an undocumented prerequisite of the tool. Ideally we could handle initialising a repo with non-pinned versions and pinning them.The text was updated successfully, but these errors were encountered: