-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Support dependency groups #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Need to think how to handle this when major updates occur. Although angular is trying to update all its core dependencies together, this is a rare case. Another example was Leaflet upgrading to 1.0 weeks/months before Mapbox supported it with their 3.x. You could perhaps override the branch/PR name for these cases but I'm not sure you can reliably still support multiple PRs for major/minor upgrades (e.g. |
|
This needs a solution not just for the branch name but also for PR title/body |
|
@guumaster brought up a related example in #48 - eslint packages Tain difference between the eslint example and angular example is that related eslint dependencies may take hours, days or weeks and not be released simultaneously like angular does. There are a few obstacles to solving this issue, most important being:
In the case of eslint, I guess it would be pretty simple to describe in written english, at least? e.g. "Put all dependencies starting with Now to consider the edge cases:
|
So one important question is: if we support dependency grouping (e.g. all angular together, or all eslint), then is it OK to disable major/non-major PR separation and instead always renovate to the latest? I have tried thinking of ways to address this and still use major/non-major separation, but have not thought of an elegant approach yet. One idea was to support grouping using one dependency as the "parent" or "master" of others. e.g. that might be Real-life example:
|
#133 could also help with this. e.g. could define |
Waiting on #133 |
e.g. upgrade angular and core angular dependencies (e.g. angular-touch) together.
The text was updated successfully, but these errors were encountered: